[4.0] Namespace System - Privacy Consent plugin#27645
[4.0] Namespace System - Privacy Consent plugin#27645zero-24 merged 9 commits intojoomla:4.0-devfrom SharkyKZ:j4/ns/plg-system-privacyconsent
Conversation
|
I have tested this item 🔴 unsuccessfully on ec00dac I am noticing that when reversing the patch I am getting a warning that plugins/system/privacyconsent/src/Field/PrivacyField.php does not exists. I am not sure if the patch is not applying correctly or something is missing from the patch. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645. |
|
Sounds like the patch wasn't applied correctly. Do you have GitHub Authentication set up in Patchtester? If not, maybe running into request limits. |
|
Even using and IDE (Eclipse) to apply from the PR it still has a problem reverting the patch. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645. |
| <filename plugin="privacyconsent">privacyconsent.php</filename> | ||
| <folder>privacyconsent</folder> | ||
| <folder>forms</folder> | ||
| <folder>src</folder> |
There was a problem hiding this comment.
No, contents of field were moved to src/Field.
|
@SharkyKZ Patch is still referencing a non-existant directory. If we need to move data due to a structure change can you please include those instructions in the patch notes? I tried with Patchtester and via my IDE and both did not work properly. |
|
I have tested this item ✅ successfully on 6974cae The structure now is forms/privacyconsent.php This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645. |
|
I have tested this item ✅ successfully on 6974cae This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645. |
|
Thanks merged. First merge with the new GitHub App, works awesome :-D |
Summary of Changes
Namespaces System - Privacy Consent plugin.
Testing Instructions
Apply patch. Delete
libraries/autoload_psr4.phpfile.Enable System - Confirm Consent plugin.
Login to frontend.
When redirected to profile form to accept consent check that Privacy Policy field appears correctly.
Documentation Changes Required
IDK.