Conversation
TinyMce follows semantic versioning. There is no reason that we should be locked down to an old patch release of 5.0.14 when the current is 5.1.5 Some help fixing the javascript in build\build-modules-js\init.es6.js to write the correct version number in the plugin xml would be appreciated
|
I have tested this item ✅ successfully on b620847 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27520. |
|
Thanks. I will test and merge in the morning. |
|
@SharkyKZ I applied your pr and ran npm i |
|
It's because regex for replacing version expects a valid version in XML. As a quick fix you can manually change the version just in the XML to something valid (e.g. back to 5.0.14) and then run |
|
Although I don't see the need for such specific regex. We could simplify it. See brianteeman#91. |
|
Thanks @SharkyKZ the regex works perfectly now. |
|
@brianteeman During testing everything works as expected, just need to confirm that the version presented in the extension manager will still be 5.0.14 or should that show 5.1.5? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27520. |
|
It will probably show 5.0.14. You can use @brianteeman You still need to commit XML changes to correct version. |
|
Refreshing the Cache worked. I noticed the version shows as "^5.1.0". Is that supposed to have the "^" in the version number? Changing |
|
I have tested this item ✅ successfully on ed91398 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27520. |
|
Can someone please check and merge this as it addresses a security vulnerability |
|
You still need to run |
|
@SharkyKZ doh - done now |
|
Can someone please check and merge this as it addresses a security vulnerability |
|
Thanks |
TinyMce follows semantic versioning. There is no reason that we should be locked down to an old patch release of 5.0.14 when the current is 5.1.5
Some help fixing the javascript in build\build-modules-js\init.es6.js to write the correct version number in the plugin xml would be appreciated