[4.0] [com_users] Fix query when searching and filtering users#26981
[4.0] [com_users] Fix query when searching and filtering users#26981SharkyKZ wants to merge 2 commits intojoomla:4.0-devfrom SharkyKZ:j4/query/com_users
Conversation
|
Hint for testers: Don't use the "never" filter for the last visit date for the test. There is another mistake for which I am currently working on a correction. |
|
2nd hint: The problem appears only with the date range filters for registered date and last visit date (of which the "never" filter for last visit date still needs a correction, see my previous comment). With other filters the problem does not appear. |
|
I have tested this item ✅ successfully on 7ca2a5c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26981. |
|
@SharkyKZ I just see there are PHPCS issues reported by drone. |
|
Sure, why not. Submitted richard67#14. |
|
@SharkyKZ Thanks a lot. That will simplify things with testing because both errors can influence each other. I worry we might have this "orWhere" problem at other places, too, that after that some other where is added or not, depending on filters. |
|
Making PR for other places now. |
Pull Request for Issue #26970 (comment) .
Summary of Changes
Fixes condition in query when filtering and searching users.
Testing Instructions
Open user list.
Set some filter and enter a keyword to search by.
Expected result
Users filtered by keywords AND filters.
Actual result
User filtered by keywords OR filters.
Documentation Changes Required
No.