Skip to content

[4.0] Export of Banner Tracks not possible#26848

Closed
Cherrypeach wants to merge 3 commits intojoomla:4.0-devfrom
Cherrypeach:TracksModalWindow
Closed

[4.0] Export of Banner Tracks not possible#26848
Cherrypeach wants to merge 3 commits intojoomla:4.0-devfrom
Cherrypeach:TracksModalWindow

Conversation

@Cherrypeach
Copy link
Copy Markdown

@Cherrypeach Cherrypeach commented Oct 28, 2019 •
edited
Loading

Pull Request for Issue #26818.
Export of Banner Tracks wasn't possible because the Modal Window was in the background.

Summary of Changes

Fixed by changing the the Position of the Modal to Body.
For this, the Buttons that opens the Modal also changes the Position of the Modal.

Testing Instructions

Go to Components -> Banners -> Tracks
Click on Export

Actual result

image

@Cherrypeach Cherrypeach reopened this Oct 28, 2019
@alikon alikon mentioned this pull request Oct 28, 2019
Closed
@waader
Copy link
Copy Markdown
Contributor

waader commented Oct 30, 2019

I have tested this item ✅ successfully on d0cb1d1

Works now, thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Oct 30, 2019

Please do it like Private Messages > My Settings, then there is no need for this layout and workaround.

@shraddhaSankpal27
Copy link
Copy Markdown

shraddhaSankpal27 commented Nov 2, 2019

I have tested this item ✅ successfully on d0cb1d1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@alikon alikon mentioned this pull request Nov 2, 2019
Closed
@rajnish-dargan
Copy link
Copy Markdown

rajnish-dargan commented Nov 2, 2019

I have tested this item ✅ successfully on d0cb1d1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@rajnish-dargan
Copy link
Copy Markdown

rajnish-dargan commented Nov 2, 2019

I have not tested this item.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@rajnish-dargan
Copy link
Copy Markdown

rajnish-dargan commented Nov 2, 2019

I have tested this item ✅ successfully on d0cb1d1

Functionality wise it is working but '?>' is coming on screen after applying patch

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@SharayuYadav
Copy link
Copy Markdown

SharayuYadav commented Nov 2, 2019

I have tested this item ✅ successfully on d0cb1d1

Functionality wise it is working.
But '?>' is shown before the 'Export' button after applying the patch.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@Quiviro
Copy link
Copy Markdown

Quiviro commented Nov 15, 2019

I have tested this item ✅ successfully on 9776218

The modal window shows in the front
#PBF19es

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@Quy Quy mentioned this pull request Nov 16, 2019
Closed
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Nov 16, 2019

Please test PR #27091 for an alternate fix.

@Quy Quy closed this Nov 17, 2019
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Nov 17, 2019

Closing in favor of PR #27091. Thank you for your contribution.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@Quy Quy reopened this Nov 24, 2019
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Nov 24, 2019

Please update per #27091 (comment)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Dec 20, 2019
@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jan 8, 2020

@Cherrypeach Please see update request per #27091 (comment).

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26848.

@jwaisner jwaisner added the Ready to take over This is an abandoned feature which can be taken over by another person to finish it. label Mar 8, 2020
@Quy Quy mentioned this pull request Mar 16, 2020
Closed
wilsonge
wilsonge reviewed Mar 16, 2020
View reviewed changes
layouts/joomla/toolbar/modal.php
<!-- Render the button -->
<joomla-toolbar-button<?php echo $id; ?> onclick="document.getElementById('modal_<?php echo $selector; ?>').open()" class="<?php echo $class; ?>" data-toggle="modal">
<joomla-toolbar-button<?php echo $id; ?> onclick="document.getElementById('modal_<?php echo $selector; ?>').open();
$(document.getElementById('modal_<?php echo $selector; ?>')).appendTo('body');"
Copy link
Copy Markdown
Contributor

@wilsonge wilsonge Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$(document.getElementById('modal_<?php echo $selector; ?>')).appendTo('body');"
document.body.appendChild(document.getElementById('modal_<?php echo $selector; ?>'));"

Not at a machine with a setup but I think this should remove the jQuery dependency from this.

@Quy Quy mentioned this pull request Mar 26, 2020
Merged
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 26, 2020

Please test PR #28472

@Quy Quy closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilsonge wilsonge wilsonge left review comments

Assignees

No one assigned

Labels

Ready to take over This is an abandoned feature which can be taken over by another person to finish it. Updates Requested Indicates that this pull request needs an update from the author and should not be tested.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.