Skip to content

Load custom.css (if exist) in Admin templates.#2684

Closed
Sophist-UK wants to merge 1 commit intojoomla:masterfrom
Sophist-UK:sophist_admin_load_custom.css
Closed

Load custom.css (if exist) in Admin templates.#2684
Sophist-UK wants to merge 1 commit intojoomla:masterfrom
Sophist-UK:sophist_admin_load_custom.css

Conversation

@Sophist-UK
Copy link
Copy Markdown
Contributor

No description provided.

@betweenbrain
Copy link
Copy Markdown
Contributor

Thanks for your contribution. Can you please create an item for this at http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549 so that it can be tested.

@Sophist-UK
Copy link
Copy Markdown
Contributor Author

Tracker 33026 created. I hope that I have provided the information needed.

@Hackwar
Copy link
Copy Markdown
Member

Hackwar commented Mar 2, 2014

Sorry, I don't think this one is necessary. This feature helps very little, because

  • it is template specific. Other admin templates don't have this feature
  • It is rarely used. I actually never came along a site/client that said "I want my backend to have more padding here" or "I want different colors for the backend".
  • The proper way would be to copy the template and then modify it there.

@Sophist-UK
Copy link
Copy Markdown
Contributor Author

Well - a lot of Fabrik users want to make lists more compact - which is where this came from.

Copying an Admin template just to change small CSS seems to be over-kill - and will provide all sorts of maintenance overhead every time a Joomla release update changes the Admin templates.

At present we are using locale-based CSS i.e. en-gb.css (how weird is that!!!) to achieve this. Custom.css would be a more standard way of achieving this, and will be more convenient when developing a multi-country web-site where admin users might change locale frequently to test how it looks/works.

This is quite a small and simple change with little risk, so I am not clear why there should be any issue with implementing it.

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Mar 2, 2014

I tend to agree with Hannes here. Copy the template and modify the CSS file directly. The template manager makes this a very easy thing to do.

@Bakual Bakual closed this Mar 2, 2014
@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Mar 2, 2014

By the way, the same could be achieved with a small system plugin which loads a custom CSS rule. I think there are various such plugins available on JED.

@Sophist-UK
Copy link
Copy Markdown
Contributor Author

Well - that was an abrupt end to the discussion - if someone could please explain to me why such a small, low risk enhancement should be treated this way, I would be grateful.

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Mar 2, 2014

Feel free to reopen the issue if you think the close was inapropriate. I closed it without seeing your first response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants