This is still an issue.

PHP Notice: Undefined property: Joomla\Component\Content\Administrator\Table\ArticleTable::$featured_up in \libraries\src\Table\Content.php on line 278

Set to null if not set $this->featured_up and $this->featured_down.

@Quy Ah it has been moved once from the #__content to the #__content_frontpage table!!! Here in the code for the content table it just has to be removed, I think. Will check.

Or maybe saving to the #__content_frontpage is missing and has to be added?

@Quy You can test with my latest commit but I am not sure if that is right. I think the Content.php is only for the #__content table.

I've pinged George with a comment here, hope we will reply: #25979 (comment)

Notices are gone, however, featured dates don't swap when finish date is less than start date.

Notices are gone, however, featured dates don't swap when finish date is less than start date.

I think this is the wrong fix then.

@Quy It has been moved from the content table to the content frontpage table during development of that and there has been something forgotten for saving, that's what I think. Or can you check if changes on these dates are saved so you later see them when going back to the form from somewhere else?

Are you suggesting that lines 277 to 284 should not be there at all?

I do see them when editing.

Yes, that's what I think. You can save changes in them? Gotta go now, brb later.

Yes changes are saved.

And if you remove the code for those columns completely? Changed still saved?

Am away from desk now, can’t test myself.

Yes.

I think I've seen in changes of that PR that changes on these 2 new columns are saved by event trigger. So I think they should be removed here. @wilsonge If you find some time, please check and comment.

@Quy And if we remove the complete function load(), too?

Hmm, I see, the function is necessary to fill times in the edit form.

@Quy Now it should be ok. Please test.

@eshiol Could you check and review and maybe test, too?

The code for loading data for display should be moved to article model's getItem() method. Date sanity checks should be moved to model's featured() method and maybe to Joomla\Component\Content\Administrator\Table\FeaturedTable class. We don't really use the latter when saving though.

@SharkyKZ I see. Will do that later.

@SharkyKZ

The code for loading data for display should be moved to article model's getItem() method.

Will that work for frontend editing, too?

No, that will have to be done in the frontend model as well.

Although I might be completely wrong with this suggestion. To me it seems that table class shouldn't load properties from other tables. But then Joomla\CMS\Table\User does exactly that with groups. So I'm not sure anymore.

@SharkyKZ I get an error 1054 Unknown column 'featured_up, featured_down' in 'field list' when testing your suggested change and opening the article for edit. The swapping of the dates is rubbish anyway, I'll leave that away. Other sanity checks seem already to be done.

@SharkyKZ @Quy Please test. Main thing is the PHP notices go away and all works well. Architectural improvements should be considered for future PR's.

I have tested this item ✅ successfully on f8557aa

@infograf768 Could you test this here, too?

I have tested this item ✅ successfully on f8557aa

tested with the json api

RTC

tks

tested with the json api

@brianteeman Was your test maybe for #26825 and not this one here? Just to be sure all is right.

my test was for here