Merged
Conversation
Sometimes you dont want to display the menu title - for example if you have an image instead. The wording for this option is "Add Menu Title" I find this confusing as the default value is yes and it would be the expected behaviour etc for a menu title for it to be displayed. This PR proposes changing the text to "Display Menu Title"
Contributor
|
I have tested this item ✅ successfully on 505a6b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26632. |
1 similar comment
|
I have tested this item ✅ successfully on 505a6b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26632. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26632. |
Contributor
|
I have tested this item ✅ successfully on 79cc136 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26632. |
Contributor
|
Merging thanks 👍 |
Contributor
Author
|
Thanks |
|
I have tested this item ✅ successfully on 79cc136 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26632. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes you dont want to display the menu title - for example if you have an image instead.
The wording for this option is "Add Menu Title" (in the link type options)
I find this confusing as the default value is yes and it would be the expected behaviour etc for a menu title for it to be displayed.
This PR proposes changing the text to "Display Menu Title"