[4.0] Update null date check in blog layout#26516
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Oct 8, 2019
SharkyKZ:j4/expired
Merged
[4.0] Update null date check in blog layout#26516wilsonge merged 1 commit intojoomla:4.0-devfrom SharkyKZ:j4/expired
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/expired
Conversation
infograf768
reviewed
Oct 8, 2019
| <?php if ($displayData->publish_down != Factory::getDbo()->getNullDate() | ||
| && (strtotime($displayData->publish_down) < strtotime(Factory::getDate())) | ||
| ) : ?> | ||
| <?php if ($displayData->publish_down !== null && strtotime($displayData->publish_down) < strtotime(Factory::getDate())) : ?> |
Member
There was a problem hiding this comment.
Normalize code?
In other files it is
<?php if (!is_null($this->item->publish_down)
Don't know what is better.
Contributor
Author
There was a problem hiding this comment.
Strict null comparison is generally faster than is_null(). There's PHP-CS-Fixer rule for removing is_null() uses which we could apply eventually.
Member
There was a problem hiding this comment.
I didn't know that. Thanks for the info.
Member
|
I have tested this item ✅ successfully on 34abc21 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26516. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 34abc21 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26516. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26516. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #26515
Summary of Changes
Updates layout to check for real null date.
Testing Instructions
Create some articles without publish down date.
Open category blog view.
Expected result
No
Expiredbadge under article title.Actual result
Expiredbadge shown.Documentation Changes Required
No.