[4.0][com_banners] fix Undefined variable: db when sticky#26512
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Oct 7, 2019
alikon:patch-117
Merged
[4.0][com_banners] fix Undefined variable: db when sticky#26512wilsonge merged 1 commit intojoomla:4.0-devfrom alikon:patch-117
wilsonge merged 1 commit intojoomla:4.0-devfrom
alikon:patch-117
Conversation
Contributor
|
I have tested this item ✅ successfully on 4b1ffab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26512. |
Member
|
I have tested this item ✅ successfully on 4b1ffab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26512. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26512. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
fix PHP Notice: Undefined variable: db in
administrator/components/com_banners/Table/BannerTable.php on line 324Testing Instructions
create a banner
set it pinned unpinned
check error log
Expected result
no notice
Actual result
notice