[4.0] Mail Templates - list view and mobile#26499
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Oct 6, 2019
Merged
Conversation
This PR adjust the column widths slightly but more importantly it applies the cell class to all cells not just the ones in the header. The real easy way to test this PR is to open the mail templates list view on a mobile (or emulator) ### Before ### After
Contributor
|
Thanks! |
Contributor
Author
|
Thanks for the quick merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjust the column widths slightly but more importantly it applies the cell class to all cells not just the ones in the header. (Otherwise what happens is that the column headers are hidden on mobile but the column data is still displayed
The real easy way to test this PR is to open the mail templates list view on a mobile (or emulator)
You might find it helpful when testing to create some dummy records in #__mail_templates with fields of various length text strings - but not essential to do this.
Before and After mobile views
Pull Request for Issue # .