[4.0] Improve newsfeed list performance when filtering by tags#26495
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Oct 8, 2019
SharkyKZ:j4/query/newsfeeds/tag
Merged
[4.0] Improve newsfeed list performance when filtering by tags#26495wilsonge merged 2 commits intojoomla:4.0-devfrom SharkyKZ:j4/query/newsfeeds/tag
wilsonge merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/query/newsfeeds/tag
Conversation
added 2 commits
October 6, 2019 22:47
Member
|
I have tested this item ✅ successfully on 8964c14 But I can confirm filtering by tags in the newsfeeds list works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26495. |
Contributor
|
I have tested this item ✅ successfully on 8964c14 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26495. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26495. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This ports changes from #19284 to backend newsfeed list view.
Testing Instructions
Create some newsfeeds with tags.
View newsfeed list in backend.
Filter newsfeeds by single and multiple tags.
Expected result
Works like before.
Documentation Changes Required
No.