[4.0] Improve contact list performance on multilingual sites#26482
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Oct 6, 2019
SharkyKZ:j4/query/contacts/multilang
Merged
[4.0] Improve contact list performance on multilingual sites#26482wilsonge merged 1 commit intojoomla:4.0-devfrom SharkyKZ:j4/query/contacts/multilang
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/query/contacts/multilang
Conversation
Member
|
I have tested this item ✅ successfully on 399b681 About performance I can't say anything because my test data set is too small. But I can confirm everything works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26482. |
Contributor
|
I have tested this item ✅ successfully on 399b681 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26482. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26482. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Replaces
JOINandGROUPclauses in query with a subquery for improved performance.Testing Instructions
Set up a multilingual site.
Enable language associations.
Create some contacts with and without associations
View contact list in backend.
Expected result
Works like before.
Documentation Changes Required
No.