[4.0] Admin Warning when no cookies#26192
Merged
wilsonge merged 8 commits intojoomla:4.0-devfrom Sep 8, 2019
Merged
Conversation
You can not login to the Joomla admin if you have cookies disabled in your browser but we never tell the user that. The login just doesnt work without any error message
wilsonge
reviewed
Sep 6, 2019
wilsonge
reviewed
Sep 6, 2019
zero-24
reviewed
Sep 6, 2019
This was referenced Sep 6, 2019
SharkyKZ
reviewed
Sep 7, 2019
dgrammatiko
reviewed
Sep 7, 2019
dgrammatiko
reviewed
Sep 7, 2019
dgrammatiko
reviewed
Sep 8, 2019
Co-Authored-By: zero-24 <zero-24@users.noreply.github.com>
Contributor
|
Thanks! |
Contributor
Author
|
thanks all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #26037
Summary of Changes
You can not login to the Joomla admin if you have cookies disabled in your browser but we never tell the user that. The login just doesnt work without any error message
This tests to see if cookies are enabled in the browser and displays an alert and message if not
Testing Instructions
Disable cookies in your web browser and try to login to the joomla admin
Expected result
Either successful login or an error message
Actual result
nothing