[4.0] Select core extensions#26126
Merged
HLeithner merged 3 commits intojoomla:4.0-devfrom Sep 2, 2019
Merged
Conversation
Removes the redundant word "show" from the language strings. It's a select field so we can assume it means show. We don't say "show" anywhere else
Contributor
|
For the Featured select type, |
Contributor
|
I have tested this item ✅ successfully on 75ad478 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26126. |
Member
|
Is "- select core -" correct ? shouldn't it be somthing like "select type"? At least I wouldn't understand out of context what "select core" means. |
Contributor
Author
|
I wasn't happy with it either but I don't think type is any better and I can't think of anything better |
|
– Select Extensions – |
Contributor
Author
|
I will go with @franz-wohlkoenig suggestion and then hopefully this can be merged |
Member
|
Still not perfect but better then "core". Thanks. |
Contributor
Author
|
small steps thanks for merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the redundant word "show" from the language strings. It's a select field so we can assume it means show. We don't say "show" anywhere else
before
after