[4.0] com_newsfeeds menu items#26092
Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom Sep 2, 2019
Merged
Conversation
Due to an sql error the complete newsfeeds menu items were not being displayed in the menu or the components dashboard
Member
|
I have tested this item ✅ successfully on 8adb4af This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26092. |
wilsonge
reviewed
Sep 2, 2019
| @@ -0,0 +1,2 @@ | |||
| UPDATE `#__menu` SET `parent_id`='12' WHERE `id`=13; | |||
Contributor
There was a problem hiding this comment.
The update file needs to be removed here. People upgrading from J3 are going to have different ID's here https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L1419-L1420 and they are currently correct. So this is just a bug in our J4 installation data. Nothing to fix for people upgrading
Contributor
Author
|
update sql files removed as requested - i only put them because... |
Contributor
|
95% of the time we should have them since in alpha 11 we're claiming to have a give or take working upgrade path (in that there's expected errors as the template swaps). This is the 5% where there's nothing to fix for those upgrading. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an sql error the complete newsfeeds menu items were not being displayed in the menu or the components dashboard
before
after