[4.0] Correct styles renderer for nonce generation#25788
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Aug 6, 2019
Merged
[4.0] Correct styles renderer for nonce generation#25788wilsonge merged 1 commit intojoomla:4.0-devfrom
wilsonge merged 1 commit intojoomla:4.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 31c3b25 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25788. |
Contributor
|
Thanks! |
Member
|
a little dot broke everything :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #25787 cc @brianteeman
Summary of Changes
make sure nonce is appended and dont overwrite the buffer
Steps to reproduce the issue
Enable the Security Headers plugin with default options
Try to create a new field of any of the following types
Which I believe are the only fields with the layout
"joomla.form.field.subform.repeatable-table"Expected result
page refreshes and you can create a field
Actual result
the template doesn't load and checking the source you can see the code in the head is broken
Documentation Changes Required
none