Skip to content

Correct implode() argument order for PHP 7.4#25784

Merged
HLeithner merged 1 commit intojoomla:stagingfrom
SharkyKZ:j3/php74implode
Aug 8, 2019
Merged

Correct implode() argument order for PHP 7.4#25784
HLeithner merged 1 commit intojoomla:stagingfrom
SharkyKZ:j3/php74implode

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

@SharkyKZ SharkyKZ commented Aug 5, 2019

Summary of Changes

Changes implode() argument order to solve deprecation messages in PHP 7.4:

Deprecated: implode(): Passing glue string after array is deprecated.

Testing Instructions

Code review.

Documentation Changes Required

No.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Aug 6, 2019

I have tested this item ✅ successfully on a1b3d38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25784.

1 similar comment
@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on a1b3d38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25784.

@ghost ghost removed the PR-staging label Aug 7, 2019
@ghost
Copy link
Copy Markdown

ghost commented Aug 7, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2019
@ghost ghost added the PR-staging label Aug 7, 2019
@HLeithner HLeithner merged commit 8756a48 into joomla:staging Aug 8, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 8, 2019
@HLeithner
Copy link
Copy Markdown
Member

Thank you for the time you invest to make J3 PHP 7.4 compatible.

@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants