[4.0] [plg_system_httpheaders] Drop option "Write headers to the configuration file"#25754
Merged
wilsonge merged 8 commits intojoomla:4.0-devfrom Sep 13, 2019
Merged
Conversation
Quy
reviewed
Aug 5, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
2 tasks
Contributor
|
I have tested this item ✅ successfully on 82630e3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25754. |
Contributor
Author
|
Thanks for your test @SharkyKZ 👍 |
Contributor
Author
|
As this here in the end removes an feature from the stable build i would like to see it merged before we hit beta. cc @wilsonge |
Contributor
|
Thanks! Frustrating it didn't work out |
Contributor
Author
|
The option has not been documented in the fist place so it does not need to be removed :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #25716
Summary of Changes
As discussed here #25716 this here is removing the htaccess / web.config option from the plugin again for the reasons explained in that issue.
Testing Instructions
Make sure the option is gone and nothing writes to the htaccess and web.config files.
make sure headers are still set correctly.
Expected result
nothing writes to the htaccess and web.config files.
Actual result
this is a option to write to the htaccess and web.config files.
Documentation Changes Required
Yes.