Skip to content

[4.0] [plg_system_httpheaders] Force http headers#25713

Merged
wilsonge merged 10 commits intojoomla:4.0-devfrom
zero-24:replaceCSP
Sep 13, 2019
Merged

[4.0] [plg_system_httpheaders] Force http headers#25713
wilsonge merged 10 commits intojoomla:4.0-devfrom
zero-24:replaceCSP

Conversation

@zero-24
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 commented Jul 27, 2019

Pull Request for Issue #25592 cc @brianteeman

Summary of Changes

rename the option to Force HTTP Headers and clearly state in the description what is happening here.

Testing Instructions

Please note the new description of the option.

Expected result

Force HTTP Headers

Actual result

Additional HTTP Headers

Documentation Changes Required

This is not documented yet but it should be ;)

Comment thread administrator/language/en-GB/en-GB.plg_system_httpheaders.ini Outdated
Thanks @brianteeman

Co-Authored-By: Brian Teeman <brian@teeman.net>
@brianteeman
Copy link
Copy Markdown
Contributor

It's still problematic
If you set "write headers to configuration file" and then options as in this screenshot
image

Then both referrer policy are written to the htaccess file
image

Although only the second one will be used.

@brianteeman
Copy link
Copy Markdown
Contributor

actually its a little more complicated than I wrote above. As sometimes you do only get the one line.

Its all very confusing. Writing headers to the file actually makes it more confusing (for me). Is it even compatible with setting headers for site or admin or both?

There is no way to delete all the headers from the htaccess. So once they have been written to the htaccess if you then disable that option no changes made to the settings will be applied

We also now have the situation that we have rules set in the htaccess, rules set in the plugin, and rules set in the component and no way to see in one place all the rules that are being applied. This will make debugging a faulty rule very hard.

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Jul 27, 2019

Can we please open a separate issue for the htaccess issue, so we can keep this here to the suggested rename of the feature?

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Jul 27, 2019

Although only the second one will be used.

Isn't that what force implies?

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Jul 27, 2019

Can we please open a separate issue for the htaccess issue, so we can keep this here to the suggested rename of the feature?

Done here: #25716 so we can keep this on renaming the feature as suggested.

Comment thread administrator/language/en-GB/en-GB.plg_system_httpheaders.ini Outdated
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Aug 5, 2019

I have tested this item ✅ successfully on dd28fac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25713.

@zero-24 zero-24 added this to the Joomla 4.0 milestone Aug 7, 2019
@wilsonge wilsonge merged commit de6643c into joomla:4.0-dev Sep 13, 2019
@wilsonge
Copy link
Copy Markdown
Contributor

This makes sense and combined with the apache file no longer being edited I believe this solves the other part of the issue. Thanks!

@zero-24 zero-24 deleted the replaceCSP branch September 14, 2019 00:00
@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Sep 28, 2019

Doc change Done.

@zero-24 zero-24 removed their assignment Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants