[com_associations] Correcting wrong Reference association in Target assoc field by infograf768 · Pull Request #25704 · joomla/joomla-cms

infograf768 · 2019-07-25T14:16:34Z

Summary of Changes

Added data-title-value to force display the correct association for the Reference item in the Target assoc field.

Thanks @robbiejackson for the code.

Testing Instructions

Create a multilingual site from clean install, using the default multilingual proposed when installing joomla. 2 languages are enough.
Go to com_associations and select articles and en-GB.
I installed French.
Click the grey icon for FR when reference is Article (en-GB)

Before patch

The reference item is wrong

After patch

Issue corrected

Note: this is a very old bug that kept unseen.

assoc field

richard67 · 2019-07-25T18:58:28Z

@infograf768 It seems the minimized js is wrong: When I have Joomla debug on so unminified file is loaded, then all is ok, but when I switch debug off so the minified file is loaded, I get following JS error in the browser console:

SyntaxError: missing } after function body sidebyside.js:1:13043
note: { opened at line 1, column 207 sidebyside.js:1:207

This seems to work, the minified version in your PR contains still the comments and so breaks syntax.

richard67 · 2019-07-25T19:13:50Z

@infograf768 Made PR against your repo for minified (or compressed or uglified or however it is called) js.

richard67 · 2019-07-25T19:22:27Z

I have tested this item 🔴 unsuccessfully on a98c1f0

Uncompressed js works, but compressed js has comments not stripped off and so has syntax errors.

See comment here: #25704 (comment)

Fix is here: infograf768#51

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25704.}

Update sidebyside.js

infograf768 · 2019-07-26T05:11:09Z

@richard67
Thanks. I just did not paste the correct minified in my local .diff, but the uncompressed file itself, so it was only partly minified... I'm getting old.
can be tested again.

richard67 · 2019-07-26T08:18:42Z

@infograf768 No, it was the heat, I am sure 😅

richard67 · 2019-07-26T08:27:59Z

I have tested this item ✅ successfully on 22dda4f

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25704.}

ghost · 2019-07-26T08:39:13Z

What i'm missing? I get:

richard67 · 2019-07-26T08:43:17Z

@franz-wohlkoenig Either cached version of minified js loaded, or patch not applied, or only partly applied.

After applying patch, force reload of the page (e.g. in Firefox: Shift-Key plus reload button left beside URL).
If 1. does not work: What do you get if you enable system debug in global config so the unminified js is used?

ghost · 2019-07-26T08:43:49Z

The Screenshot is before Patch.

richard67 · 2019-07-26T08:45:11Z

@franz-wohlkoenig Then it is correct. You see the empty English association at the right hand side? Will be correctly filled after patch is applied and changed js is loaded.

ghost · 2019-07-26T08:49:22Z

I have tested this item ✅ successfully on 22dda4f

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25704.}

ghost · 2019-07-26T08:49:45Z

Status "Ready To Commit".

infograf768 · 2019-07-26T09:24:40Z

Note: I see other weird stuff:

@franz-wohlkoenig screen shot does not display the fields in the same order than mine. I found out that this depends on the order of the Content Languages in the Manager and not on the alpha order of the lang tags which is used in the usual Language field.
Not a big deal: we can live with that. :)
When installing a language, the Content Language created only contains part of the lang tag i.e. the country code, contrary to the default en-GB.
If I install de-AT it will be German(AT).
That should be corrected because we may have 2 different languages with the same country code and it would be hard to differentiate.
Looking into that now

richard67 · 2019-07-26T09:32:31Z

@infograf768 2. Is not an issue for me. Spanish(ES) and Catalan(ES) would be easy to distinguish for me.

Harder is maybe German(AT) and German(DE) and so on, but that's the other way round.

On my site I have both country and language as complete word in my content language name, and text is in the particular language, like "Deutsch (Deutschland)", "English (United Kingdom)" or "Русский (Россия)", so people find it in their language in the link title of the language switcher, that's how I like it.

infograf768 · 2019-07-26T09:32:43Z

Concerning 2. It looks related to the install.xml from which the LanguageAdapter picks the Title

// Set the content language title as the language metadata name.
			$contentLanguageTitle = $siteLanguageManifest['name'];

This means we have to instruct TTs to pay attention to that. or modify code

richard67 · 2019-07-26T09:33:30Z

@infograf768 Yes and that's why it is weird, because different TT use different way, so the result is not consistent.

richard67 · 2019-07-26T09:34:59Z

We should force TTs to use the "Deutsch (Deutschland)", "English (United Kingdom)" or "Русский (Россия)" way for the content language names (or titles) and another standardized way for the site or admin language names shown in the backend.

infograf768 · 2019-07-26T09:35:59Z

@richard67
Yep. Will share this in TT Coordination.

richard67 · 2019-07-26T09:36:38Z

Admin and site languages should always be like "de-DE", "en-GB" and so on so you can switch backend language and still understand it. For content language see above.

infograf768 · 2019-07-26T09:39:43Z

@richard67

We should force TTs to use the "Deutsch (Deutschland)", "English (United Kingdom)" or "Русский (Россия)"

Will share this in TT Coordination. I think though that the real tag is enough because of the size of the fields. Admin will have to modify as they like and as you did.
So, we would have for metadata French (fr-FR) for example.

richard67 · 2019-07-26T09:41:51Z

I can live with that as long as it is consistent at the end ;-)

infograf768 · 2019-07-26T10:05:34Z

It would be consistent with what we have for en-GB.
Just did it for French:

infograf768 · 2019-07-28T08:24:52Z

@HLeithner
Please merge.

HLeithner · 2019-07-31T10:00:12Z

thx

[com_associations] Correcting wrong Reference association in Target

a98c1f0

assoc field

infograf768 requested a review from wilsonge as a code owner July 25, 2019 14:16

joomla-cms-bot added the PR-staging label Jul 25, 2019

Update sidebyside.js

f3739ad

This seems to work, the minified version in your PR contains still the comments and so breaks syntax.

Merge pull request #51 from richard67/patch-1

22dda4f

Update sidebyside.js

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 26, 2019

Merge branch 'staging' into reference_target_item_display

011873f

Merge branch 'staging' into reference_target_item_display

1be2a37

HLeithner merged commit 4f3ae92 into joomla:staging Jul 31, 2019

HLeithner added this to the Joomla! 3.9.11 milestone Jul 31, 2019

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 31, 2019

infograf768 mentioned this pull request Aug 4, 2019

[4.0] Different behaviour for adding an associated item in multilingual associations #25646

Open

infograf768 deleted the reference_target_item_display branch November 4, 2019 19:21

Uh oh!

Conversation

infograf768 commented Jul 25, 2019

Summary of Changes

Testing Instructions

Before patch

After patch

Uh oh!

richard67 commented Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Jul 25, 2019

Uh oh!

richard67 commented Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented Jul 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Jul 26, 2019

Uh oh!

richard67 commented Jul 26, 2019

Uh oh!

ghost commented Jul 26, 2019

Uh oh!

richard67 commented Jul 26, 2019

Uh oh!

ghost commented Jul 26, 2019

Uh oh!

richard67 commented Jul 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 26, 2019

Uh oh!

ghost commented Jul 26, 2019

Uh oh!

infograf768 commented Jul 26, 2019

Uh oh!

richard67 commented Jul 26, 2019

Uh oh!

infograf768 commented Jul 26, 2019

Uh oh!

richard67 commented Jul 26, 2019

Uh oh!

richard67 commented Jul 26, 2019

Uh oh!

infograf768 commented Jul 26, 2019

Uh oh!

richard67 commented Jul 26, 2019

Uh oh!

infograf768 commented Jul 26, 2019

Uh oh!

richard67 commented Jul 26, 2019

Uh oh!

infograf768 commented Jul 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented Jul 28, 2019

Uh oh!

HLeithner commented Jul 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

richard67 commented Jul 25, 2019 •

edited

Loading

richard67 commented Jul 25, 2019 •

edited

Loading

infograf768 commented Jul 26, 2019 •

edited

Loading

richard67 commented Jul 26, 2019 •

edited

Loading

infograf768 commented Jul 26, 2019 •

edited

Loading