Correcting RTL in Postinstall#25604
Merged
HLeithner merged 7 commits intojoomla:stagingfrom Jul 31, 2019
Merged
Conversation
Quy
reviewed
Jul 17, 2019
|
I have tested this item 🔴 unsuccessfully on 0e91a57 without PR: Bullet is on Start of Title
with PR: Bullet is on right End of Title (as Date).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
Member
Author
|
I see other errors with the feed text which should be ltr. Looking at this now. |
Member
Author
|
@Quy @franz-wohlkoenig
|
|
I have tested this item 🔴 unsuccessfully on ce28993 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
Member
Author
|
@franz-wohlkoenig This is not due to this patch but an error in the Persian ini file: a once corrected to all is fine:
|
|
I have tested this item ✅ successfully on 5346788 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
Member
Author
|
@Quy |
Quy
reviewed
Jul 25, 2019
administrator/components/com_postinstall/views/messages/tmpl/default.php
Outdated
Show resolved
Hide resolved
…efault.php Co-Authored-By: Quy <quy@fluxbb.org>
Member
Author
|
Modified as requested. |
Contributor
|
I have tested this item ✅ successfully on 0317860 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
Member
Author
|
@HLeithner |
Member
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Postinstall component uses the admin
mod_feedto display the Release News from the Joomla Project.But it does not take into account a RTL language.
Alignment and direction of date are set by default to LTR
This PR corrects that by:
rssrtlto RTL if lang is RTL for the envelopping<div>in postinstall default.php<ulto force the feed texts to be aligned left as these are in English in mod_feed.Testing Instructions
Install Persian language and switch admin to Persian.
Load
index.php?option=com_postinstall&eid=700Before patch
The date in the left column is not displayed as RTL and is aligned left
After patch
The date is now RTL and alignment is right
Note
For 4.0 the modified code for mod_feed will be slightly different as we have no more
<?php echo $params->get('moduleclass_sfx'); ?>and the class for the feed texts is now
newsfeed list-group