[staging] Adding missing lang strings for XTD plugins#25475
Merged
HLeithner merged 6 commits intojoomla:stagingfrom Jul 12, 2019
Merged
[staging] Adding missing lang strings for XTD plugins#25475HLeithner merged 6 commits intojoomla:stagingfrom
HLeithner merged 6 commits intojoomla:stagingfrom
Conversation
Quy
reviewed
Jul 8, 2019
Quy
reviewed
Jul 8, 2019
Quy
reviewed
Jul 8, 2019
Member
Author
|
@Quy Should be OK now. tks. |
Contributor
|
I have tested this item ✅ successfully on 659eeca This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475. |
8aaa7f5 to
978ca74
Compare
Member
Author
|
@Quy was showing as untranslated for the Field xtd plugin. |
Contributor
|
I have tested this item ✅ successfully on 9442de7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475. |
Member
|
I have tested this item ✅ successfully on 22b09f6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25475. |
Member
Author
|
@HLeithner |
Member
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #25344
Replaces #25472
Summary of Changes
Loading main administrator joomla xx-XX.ini is not a good idea as it may override some frontend xx-XX.ini strings.
The only reason
$lang->load('joomla', JPATH_ADMINISTRATOR);was added for com_menus and com_modules was to get these strings from backend.These calls are now deleted.
The correct solution was to add then in frontend.
Some looks weird to add:
but as they show as untranslated when using the Field xtd, I added them.
(it would be interesting to find out why they are needed there and if corrected, delete them in 4.0)
Testing Instructions
Set Language debug on and load each xtd plugin when editing an article in frontend.
Check if any string is missing.
After patch
The main display change with Protostar is the corrected
JGLOBAL_LIST_ALIAS="(<span>Alias</span>: %s)"string.@SharkyKZ @Quy