[mod_tags_popular] Exclude restricted items from count#25473
[mod_tags_popular] Exclude restricted items from count#25473HLeithner merged 2 commits intojoomla:stagingfrom SharkyKZ:j3/tagsPopularAccess
Conversation
|
@kofaysi please test (how to: https://docs.joomla.org/Testing_Joomla!_patches) |
|
@SharkyKZ |
|
@infograf768, no, mod_tags_similar doesn't have this issue. |
|
I have tested this item 🔴 unsuccessfully on cc7bcd8 But, the I'm sorry, I'm hesitating to write This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25473. |
|
That is expected behavior. |
|
Do you mean that the module itself is stricken by a "multiple personality disorder"? If that is acceptable then the PR works as expected. |
|
Tags component supports multiple content types. Tag view displays all content types by default, although filtering by type capability does exist. It's not implemented in the module though. |
Can you double check this? I can't reproduce the issue. |
Negative. The number next to the tags includes the number of contacts and weblinks, but sometimes it differs: the list (after clicking on a tag) includes sometimes more items than the count displayed next to the tag. I think that the list includes items of the nested tags (sub-tags). The count include only items of that particular (parent) tag. Note: it was a coincidence before in count of the articles (with nested tags, too) and total count related to that (parent) tag. |
|
I think it is correct that the counts in the module are related to the parent tags only and they ignore the children tags. On the other hand, it is a very good idea to let the user know that there is more content available and show them the content somehow. It is unfortunate that the list of a content to a tag and its children tags is melted into a mixed list (titles are sorted alphabetically, aren't they?). I think that the generated list shouldn't be mixed.
|
@kofaysi I suggest to open a new Issue to discuss the topic (also reference to this Issue). |
|
I have tested this item ✅ successfully on cc7bcd8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25473. |
|
I have tested this item ✅ successfully on cc7bcd8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25473. |
|
Status "Ready To Commit". |
|
thx |
Pull Request for Issue #23582 .
Summary of Changes
Adds access filter when counting items.
Testing Instructions
Create two articles.
Assign them the same tag.
Set access of one article to
Registered.Publish
Tags - Popularmodule.In the module enable
Display Number of Itemsoption.View the module in frontend. Inspect the number of items next to the tag:
a) As guest.
b) As logged in user.
Expected result
a) 1
b) 2
Actual result
a) 2
b) 2
Documentation Changes Required
No.