Correct class, icon and text for contact error warning in multilanguage status module#25426
Conversation
|
@brianteeman I'd like to know your opinion if both changes, 1. icon and class, and 2. the removal of "Warning! " from the beginning of the text are good, or if you think only one of them is better. I think both together is most consistent with other warnings in the multilanguage status module's modal. I've made separate commits so each change can be cherry-picked. |
|
In joomla 3 you will have to keep the word"warning" in the text. In joomla 4 these messages should all have a headline saying "warning" (and if they dont yet then its just because its on my todo) The other changes are fine and enough to resolve this issue |
|
@brianteeman Hmm, the other texts dont's start with "Warning! ". What these warnings all have is a hidden (class="element-invisible") span with |
|
and the others are wrong which is why I fixed them in j4 ;) |
|
Ahh. Got it. Will undo the corresponding commit to remove the test part. |
|
The hidden span is for screen reader users as they cant see the icon or colour |
This reverts commit 1416f3e.
|
Yes, that's why I changed that, too. Thanks for advise. I really appreciate that. PR should be ready now. |
|
I have tested this item ✅ successfully on 19ba859 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25426. |
1 similar comment
|
I have tested this item ✅ successfully on 19ba859 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25426. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25426. |
|
Thanks Guys for your Work. |
|
thx |
|
Thanks |
Pull Request for Issue #25415 .
Summary of Changes
2. Remove text "Warning! " from the beginning of the language string for that message.These 2 changes are made with separate commits for each change, so if it turns out that only one of them is accepted, then it can be cherry-picked.Testing Instructions
See issue #25415 .
Expected result
Consistent display of all warnings, i.e. show contact related warning like all the others with warning class and icon
but no text "Warning! " at the beginning.Actual result
All warnings have warning class and icon and no text "Warning! " at the beginning. Only the text related to contact errors has class and icon for info but text "Warning! " at the beginning.
Documentation Changes Required
None.