[4.0] Banners - nullable datetime fields#25360
Conversation
Pull Request for Issue joomla#16788 ....same as joomla#24675 for contacts Summary of Changes some datetime fields should be nullable as default - publish_up - publish_down - checked_out_time ### Testing Instructions test com_banners ### Expected result banners should works as before
| `checked_out_time` datetime, | ||
| `publish_up` datetime, | ||
| `publish_down` datetime, | ||
| `reset` datetime NOT NULL DEFAULT '0000-00-00 00:00:00', |
There was a problem hiding this comment.
I have just copied from the example. So I don't know
There was a problem hiding this comment.
@alikon In your PR #24675 , which is the template for this here, you handled only columns checked_out_time, publish_up and publish_down. What do you think, should Brian continue like that, or should he handle also other columns which should be nullable? From a functional point of view, the reset column here should be nullable, too, for the case if there never has been a reset. On the other hand, if in all other PRs right now only the 3 columns mentioned above are handled, this PR here would be consistent with it, and we would know we have to check for other columns later again for all components. My opinion is that it should be consistent, so this PR is ok for me now. But I'd like to know your opinion on it, too.
There was a problem hiding this comment.
well, different tables have different fields/behaviour, that said, following this comment as only an example #24675 (comment) and without a proper effort to try to move forwrad joomla db schema from mambo times ....... (sorry for the rant)....for me too the reset field should be nullable......but again without a full re-think about db schema ......
p.s
thanks Brian
|
@brianteeman i guess #16788 cannot be closed for now. |
|
No not yet there is still more components |
|
@brianteeman There is also a column |
|
Thanks! |
|
Thanks |
Pull Request for Issue #16788 ....same as #24675 for contacts - I really just copied the work of others (someone has to)
Summary of Changes
some datetime fields should be nullable as default
Testing Instructions
test com_banners
Expected result
banners should works as before