The old schema updates 3.9.7-2019-05-16.sql should be corrected, too, so we in future don't create the error which new schema updates provided by this PR shall fix on other sites. Problem is that I don't know if the helpsite parameter always is placed somewhere in the middle of the json, or if it also can be first or last parameter in the list.

I still say the param shouldn't be touched. Empty the 3.9.7-2019-05-16 changeset and have this change to fix the broken database fields. It was getting rid of the param that broke things in the first place and it was an unnecessary action.

@mbabker

... have this change to fix the broken database fields.

You mean like in this PR, with new schema update files? Or just as howto in a forum?

Is the change in this PR here safe? Or can it be that the helpsite parameter is not in the middle but at the beginning or the end of the json list so we need a more sophisticated replacement?

I removed the content from the old sql file as michael suggested.

yes make sense to remove the buggy replace imo

Should be good now.

If helpsite can also be at beginning or end of the json, we also have to replace {, with {and ,} with }.

I tested the patch on an updated 3.9.7, works fine and restores the JSON

normally the helpsite is between 2 other parameters I don't think that it's possible that the ,, are at the beginning or the end...

Should the obsolete schema updates which are deleted with this PR also be deleted on already updated sites, i.e. added somehwre here https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/script.php#L1989 ?

It will be overridden anyway, not sure if it makes sense to remove it.

It's fine as an empty file. Or change the file contents to have a SQL comment that way it's clear why there are no queries in it.

# Query removed, see https://github.com/joomla/joomla-cms/pull/25177

I like Michael's suggestion in his previous comment, have a comment in the wrong sql file.

lgtm

I added the comment.

I have tested this item ✅ successfully on 872c9ce

Tested with 3.9.7 site with user having parameters with error caused by wrong helspite removal.

I have tested this item ✅ successfully on 872c9ce

thx for the help, release is out.

Hello! after having done the update of joomla 3.7.5 to 3.9.10 I received this error: [17-Jul-2019 13:28:13 Etc/GMT] PHP Fatal error: Call to undefined method JLanguageHelper::parseIniFile() in /home/pescwj6v/public_html/libraries/src/Language/Language.php on line 803

My site is in pt-BR (portuguese-brazil), and both the site and the administrator are without access, the pages are blank. Does anyone have any solutions to this error?

@pescweb Please ask on Forum as this Repository is for coding.