Skip to content

Fix doc block to use correct element order#25175

Merged
HLeithner merged 1 commit intojoomla:stagingfrom
mbabker:fix-github-doc
Jun 11, 2019
Merged

Fix doc block to use correct element order#25175
HLeithner merged 1 commit intojoomla:stagingfrom
mbabker:fix-github-doc

Conversation

@mbabker
Copy link
Copy Markdown
Contributor

@mbabker mbabker commented Jun 11, 2019

Doc blocks should generally be in this order:

  • Short description
  • Long description
  • Tags (order specified in coding standards validators)

The doc block for JGithubPackageData is in the wrong order, which results in incorrect output when parsing the doc blocks for the API documentation, see https://api.joomla.org/cms-3/deprecated.html#joomla/github/package/data.php and https://api.joomla.org/cms-3/classes/JGithubPackageData.html (the long description for the deprecation is actually the class' description). Putting things in the right order will ensure the parser correctly handles this file.

@HLeithner HLeithner merged commit ce3cf03 into joomla:staging Jun 11, 2019
@HLeithner
Copy link
Copy Markdown
Member

thx

@HLeithner HLeithner added this to the Joomla 3.9.8 milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants