Skip to content

Code style. Remove space. plg_extension_joomla#25079

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
ReLater:patch-2
Jun 1, 2019
Merged

Code style. Remove space. plg_extension_joomla#25079
wilsonge merged 1 commit intojoomla:stagingfrom
ReLater:patch-2

Conversation

@ReLater
Copy link
Copy Markdown
Contributor

@ReLater ReLater commented Jun 1, 2019

Summary of Changes

  • Removed space.

Testing Instructions

  • Code review. It's obvious.

Additional comment

  • The same in Joomla 4. I don't know if we need an additional pr for it(?)

@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on c04e31b

Code review.

@wilsonge Does that need a PR for 4.0-dev, too, or will it later be merged into 4.0-dev anyway?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25079.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jun 1, 2019

I have tested this item ✅ successfully on c04e31b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25079.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jun 1, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25079.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 1, 2019
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jun 1, 2019

Not necessary as it will be merged later.

@wilsonge wilsonge merged commit 71266bd into joomla:staging Jun 1, 2019
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Jun 1, 2019
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jun 1, 2019

Thanks! As quy said. everything in staging will end up in j4

@wilsonge wilsonge added this to the Joomla 3.9.7 milestone Jun 1, 2019
@ReLater ReLater deleted the patch-2 branch June 1, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants