Skip to content

[4.0] Add prepared statements for plg_content_pagenavigation#25051

Merged
wilsonge merged 32 commits intojoomla:4.0-devfrom
HLeithner:prepared-plg-content-pagenavigation
Mar 27, 2020
Merged

[4.0] Add prepared statements for plg_content_pagenavigation#25051
wilsonge merged 32 commits intojoomla:4.0-devfrom
HLeithner:prepared-plg-content-pagenavigation

Conversation

@HLeithner
Copy link
Copy Markdown
Member

@HLeithner HLeithner commented May 29, 2019

Summary of Changes

Updated SQL queries to prepared statements and made some cleanups around the queries.

Testing Instructions

Use the plugin in all ways you can think of.

  • Activate the page navigation feature
  • create multiple articles in the same category
  • check the frontend if you can navigate to the next article
  • set the ordering in the menu and the global options, try different dates (create,published, modified)

Expected result

Nothing changed.

Quy
Quy reviewed May 29, 2019
View reviewed changes
@ghost ghost changed the title Add prepared statements for plg_content_pagenavigation [4.0] Add prepared statements for plg_content_pagenavigation May 30, 2019
Quy
Quy reviewed May 31, 2019
View reviewed changes
Quy
Quy reviewed May 31, 2019
View reviewed changes
Quy
Quy reviewed May 31, 2019
View reviewed changes
Quy
Quy reviewed May 31, 2019
View reviewed changes
Quy
Quy reviewed May 31, 2019
View reviewed changes
Quy
Quy reviewed Jun 23, 2019
View reviewed changes
SharkyKZ
SharkyKZ reviewed Jun 26, 2019
View reviewed changes
@Quy Quy mentioned this pull request Jul 2, 2019
Merged
SharkyKZ
SharkyKZ reviewed Jul 3, 2019
View reviewed changes
SharkyKZ
SharkyKZ reviewed Jul 9, 2019
View reviewed changes
SharkyKZ
SharkyKZ reviewed Jul 9, 2019
View reviewed changes
@SharkyKZ
Copy link
Copy Markdown
Contributor

SharkyKZ commented Jul 9, 2019

Currently (with or without patch) the plugin doesn't return any articles due to invalid workflow query. Do you want to add a fix in here? Or should we wait until this is merged first?

@HLeithner @SharkyKZ
Apply suggestions from code review
5711e6e 
Co-Authored-By: SharkyKZ <sharkykz@gmail.com>
@HLeithner
Copy link
Copy Markdown
Member Author

HLeithner commented Jul 9, 2019

@SharkyKZ Can you point me to the workflow query problem?

@SharkyKZ
Copy link
Copy Markdown
Contributor

SharkyKZ commented Jul 9, 2019

Here are related PRs #24785, #24494.

@HLeithner
Copy link
Copy Markdown
Member Author

HLeithner commented Jul 10, 2019

I it's not a problem of the PR I would merge it WF needs a major update anyway.

@SharkyKZ
Copy link
Copy Markdown
Contributor

SharkyKZ commented Jul 15, 2019

Fix conflict please.

@HLeithner
Merge branch '4.0-dev' into prepared-plg-content-pagenavigation
8154261 
# Conflicts:
#	plugins/content/pagenavigation/pagenavigation.php
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jan 25, 2020

OK let's get some tests here - this is the last PR in the prepared statements project - would be nice to get that finally shut down

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 25, 2020

See #27587 which prevents testing.

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jan 26, 2020

That issue is unrelated to this plugin I’ve clarified there

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Feb 9, 2020

Please fix conflicts.

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Feb 10, 2020

Should be fixed

Quy
Quy reviewed Feb 20, 2020
View reviewed changes
@alikon alikon self-requested a review February 20, 2020 18:54
@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 22, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Mar 17, 2020

@HLeithner can you spend some time fixing the issue raised here please

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Mar 27, 2020

@HLeithner bump again

@HLeithner
Copy link
Copy Markdown
Member Author

HLeithner commented Mar 27, 2020

Should work again now...

@Quy Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Mar 27, 2020
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Mar 27, 2020

I have tested this item ✅ successfully on c8f3afc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25051.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 27, 2020

I have tested this item ✅ successfully on c8f3afc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25051.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 27, 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25051.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 27, 2020
@wilsonge wilsonge merged commit f17db77 into joomla:4.0-dev Mar 27, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Mar 27, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 27, 2020
@HLeithner HLeithner deleted the prepared-plg-content-pagenavigation branch March 29, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

+2 more reviewers

@SharkyKZ SharkyKZ SharkyKZ left review comments

@alikon alikon alikon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

8 participants

@HLeithner @SharkyKZ @Quy @wilsonge @JazParkyn @waader @alikon @joomla-cms-bot