Correct archived article links in search results#24990
Correct archived article links in search results#24990SniperSister merged 2 commits intojoomla:stagingfrom SharkyKZ:j3/plgSearchContent
Conversation
|
@HerKle @beejay41 please test > https://docs.joomla.org/Testing_Joomla!_patches |
I've applied the change to my test system and it now returns the expected link. Bug fixed. My only criticism is that there are now 2 identical pieces of code ( for normal and archived articles), so if there is a need to make changes in future, the duplicate (archive) code could be overlooked. Also, only do things once. |
|
@beejay41 please mark your test as successfully > https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results |
|
@beejay41 I was thinking the same thing. But I'll leave code cleanup for another time. I'm also not sure whether the queries are correct. They don't look for articles in archived categories. |
|
there is no archived category iirc it's a value of the state field maybe (2) |
|
This doesnt look correct to me. You need to also see what the archive module and archive view create |
|
@alikon same thing. Query looks for articles in published but not in archived categories. Both when looking for published and archived articles. |
|
@brianteeman this is fine. Links to archive view were added as a workaround for some 1.5 issue. See https://developer.joomla.org/joomlacode-archive/issue-23764.html. |
Sorry, new to this. I did as requested, and it looks to have updated the Joomla tracker, but not here. 2FA error, but I'm not using 2FA anywhere here. |
|
tried to alter test of @beejay41 but get: |
|
@franz-wohlkoenig you will need to speak to @HLeithner about this. There has been a change in the authentication settings on github which you are hitting and need to resolve |
|
Michael is working on this problem. |
|
@HLeithner I assumed someone was - I just wanted to let @franz-wohlkoenig know |
|
thanks for info, guys. @beejay41 so please wait until this Problem is solved. |
|
It's all sorted. |
|
Comment on it, update it, do anything that triggers a webhook from GitHub to the tracker and that will sort it. It'll take me longer to log into the server and run the CLI command than it will for someone to do that. |
|
tks, that worked. |
|
I have tested this item ✅ successfully on ba42aa2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24990. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24990. |
|
Merged, thanks! |

Pull Request for Issue #22395.
Summary of Changes
Corrects links to archived articles in search results.
Testing Instructions
Make sure
Archived Articlesoption is enabled inSearch - Contentplugin.Create an article. Set status to archived.
Search for the article using standard search (
com_search).Inspect link to article in search results.
Expected result
Link opens article, e.g.
http://localhost/index.php/site-map/articles/9-uncategorised/67-whats-new-in-15Actual result
Link opens archived view, e.g.
http://localhost/index.php/using-joomla/extensions/components/content-component/archived-articles/2019?view=archive&month=5Documentation Changes Required
No.