Changed the default value to type double#24971
Merged
HLeithner merged 2 commits intojoomla:stagingfrom Jun 1, 2019
Quy:patch-1
Merged
Changed the default value to type double#24971HLeithner merged 2 commits intojoomla:stagingfrom Quy:patch-1
HLeithner merged 2 commits intojoomla:stagingfrom
Quy:patch-1
Conversation
Closed
Member
|
I have tested this item ✅ successfully on aa5cc84 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24971. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on aa5cc84 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24971. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24971. |
Member
|
@HLeithner I think this should me merged. |
Member
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of PR #15743
The PHPdoc declares the variable as "double"
@param double $startTimebut the method initialises its default value with an "integer" instead
$startTime = 0Summary of Changes
Changed the default value to type double
Testing Instructions
Code review