[4.0] Move a subform template out of the form scope, for IE compatibility.#24944
Closed
Fedik wants to merge 5 commits intojoomla:4.0-devfrom
Closed
[4.0] Move a subform template out of the form scope, for IE compatibility.#24944Fedik wants to merge 5 commits intojoomla:4.0-devfrom
Fedik wants to merge 5 commits intojoomla:4.0-devfrom
Conversation
| document.body.append(tmplElement[0]); | ||
| } | ||
|
|
||
| this.templateElement = tmplElement[0]; |
There was a problem hiding this comment.
Use array destructuring prefer-destructuring
This was referenced May 18, 2019
Contributor
Related issue #23822 |
Member
|
This should be |
Member
Author
|
@C-Lodder yeah, you are right, thanks, I will change |
build/media_source/system/js/fields/joomla-field-subform.w-c.es6.js
Outdated
Show resolved
Hide resolved
build/media_source/system/js/fields/joomla-field-subform.w-c.es6.js
Outdated
Show resolved
Hide resolved
Contributor
|
This PR can probably be closed as the production department have decided to adopt a browser support policy of PROD2019/005 - Change minimum version requirements for all browsers to n-2 and drop support for Internet Explorer. https://volunteers.joomla.org/departments/production/reports/1031-production-dept-meeting-may-28-2019 |
Member
Author
|
yeah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24832 for Joomla 4.0 version
This fix the subform field in IE, when one of subfield are required.
Testing Instructions
before test run
npm installPlease look for related issue for details.