[4.0] Improve Text on Modal: Batch process language labels#24817
[4.0] Improve Text on Modal: Batch process language labels#24817pe7er wants to merge 2 commits intojoomla:4.0-devfrom pe7er:batch-process-language-labels
Conversation
|
I can create a similar PR for:
|
|
The length of the text should not be a consideration as it will always be different lengths in other languages |
I know. Could you please look at the suggested improvement itself (besides the length) ? |
|
Although I do like the change for |
|
Is it necessary to include Maybe remove the second label and replace the first label with |
|
I have tested this item ✅ successfully on 734666a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24817. |
|
I have tested this item ✅ successfully on 734666a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24817. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24817. |
| JLIB_HTML_BATCH_MENU_LABEL="Select a Category for your Selection" | ||
| JLIB_HTML_BATCH_MOVE="Move" | ||
| JLIB_HTML_BATCH_MOVE_QUESTION="Do you want to move the items or make a copy of them?" | ||
| JLIB_HTML_BATCH_MOVE_QUESTION="Copy or Move the items?" |
There was a problem hiding this comment.
| JLIB_HTML_BATCH_MOVE_QUESTION="Copy or Move the items?" | |
| JLIB_HTML_BATCH_MOVE_QUESTION="Move or Copy the items?" |
To be consistent with the next language string.
There was a problem hiding this comment.
Given the copy option shows before the move option in the UI probably the correct thing is to change the string below too (and also keeps it alphabetical)
|
I agree with JM here to an extent. Whilst I think it's clear you don't have to select a category (as the default is "Don't move or copy". Which is the same for all other options that modify data (otherwise you can argue they are all also issues), I would imagine the default string in the value field being the only way of understanding you can move or copy items could be confusing to people unfamiliar to batch (I hesitate to say new users because batch isn't exactly a brand new user feature) I'd be interested in hearing more opinions here before merging (clearly no need to more testers as the patch itself is self-explanatory) |
|
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24817 |
|
Please continue discussion/testing in PR #28447. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24817. |
IMHO some of the text in the Batch process the selected articles modal is too long:
This PR rewrites that text to:
Summary of Changes
On the current modal some of the text seems a bit too long:
Testing Instructions
Content > Articles > select some articles > click on Batch
Select a category so that the Copy / Move question is shown.
Expected result
This PR makes two of the labels shorter so that IMHO it looks nicer,
but also easier to read and understand:
Suggestion (NOT in this patch)
If this PR gets accepted then I suggest to move the radio buttons of Copy / Move to the left
by removing the left margin in administrator/templates/atum/css/template.css line 470: