com_fields vs cli finder indexer#24630
com_fields vs cli finder indexer#24630HLeithner merged 4 commits intojoomla:stagingfrom alikon:patch-116
Conversation
thanks @Quy Co-Authored-By: alikon <optimus4joomla@gmail.com>
|
@jjnxpct can you test this pr? |
| { | ||
| $this->addTablePath(JPATH_ADMINISTRATOR . '/components/com_fields/tables'); | ||
| } | ||
| $this->addTablePath(JPATH_ADMINISTRATOR . '/components/com_fields/tables'); |
There was a problem hiding this comment.
I would add here a comment why this is necessary as normally you don't have to write this in a model. The environment should be set up properly upfront.
There was a problem hiding this comment.
or did you think it is better to add a define with JPATH_COMPONENT in the cli script ?
|
I tested this and the error is now gone in the cron email. Excellent. |
|
@jjnxpct please mark your test as successfully at Issue Tracker. |
@franz-wohlkoenig : Not sure how to do that. Sorry, I'm getting lost in this GitHub stuff... |
|
No Problem @jjnxpct. At https://docs.joomla.org/Testing_Joomla!_patches scroll to Subhead "Recording test results", this might be enough information. If not, please comment :-) |
|
I have tested this item ✅ successfully on 4506625 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630. |
|
@franz-wohlkoenig : Thanks! Just added the successful test. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630. |
|
@ReLater can you please test? |
|
Hi! After updating Joomla the errors came back, because we tested this by changing a core file and now this file has been overriden by the Jomla update. So I guess this means this has not been added to the Joomla release. Not sure how this works, but when can this 'fix' be expected in a next Joomla release? So we don't have to keep patching this ;-) |
|
We need 2 successful tests then it can be merged in to core. |
|
OK, thanks for letting me know. Hope someone else can test this to. |
|
I have tested this item ✅ successfully on 4e4423e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630. |
|
thx |
Pull Request for Issue #24607
Summary of Changes
always add table search path
Testing Instructions
run finder indexr from cli no warning expected
Expected result
custom fields works as before
and cli finder_indxer runs without warning
Actual result
cli finder_indexer gives warning
cc:@laoneo