Skip to content

Remove chosen from com_tags#24627

Merged
HLeithner merged 2 commits intojoomla:stagingfrom
brianteeman:remove_chosen_from_tags
Jun 5, 2019
Merged

Remove chosen from com_tags#24627
HLeithner merged 2 commits intojoomla:stagingfrom
brianteeman:remove_chosen_from_tags

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Chosen is not accessible so we shouldnt use it unless it offers something useful.

In the tags component in the front end it is used for display #

This doesnt require or benefit from chosen so this simple PR returns it to regular and accessible list

Chosen is not accessible so we shouldnt use it unless it offers something useful.

In the tags component in the front end it is used for display #

This doesnt require or benefit from chosen so this simple PR returns it to regular and accessible list
@zwiastunsw
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 7953146


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24627.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Apr 17, 2019

I have tested this item ✅ successfully on 7953146


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24627.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Apr 17, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24627.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 17, 2019
@ghost ghost added the PR-staging label Apr 18, 2019
@ghost ghost changed the title [staging] Remove chosen from com_tags Remove chosen from com_tags Apr 18, 2019
@HLeithner HLeithner merged commit 93dbe71 into joomla:staging Jun 5, 2019
@HLeithner
Copy link
Copy Markdown
Member

thx

@HLeithner HLeithner added this to the Joomla 3.9.7 milestone Jun 5, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 5, 2019
@brianteeman brianteeman deleted the remove_chosen_from_tags branch June 5, 2019 15:58
@mbabker
Copy link
Copy Markdown
Contributor

mbabker commented Jun 5, 2019

LOLOLOLOL you merged this one but not the other because "it might break templates". That's hilarious.

@HLeithner
Copy link
Copy Markdown
Member

I have no idea why you're laughing at me.

I someone wants to remove the chosen she/he can override the Frontend template. With this pr we remove a feature unexpected for the user.

In the backend you likely will not break anything if you remove chosen.

@brianteeman
Copy link
Copy Markdown
Contributor Author

Fyi both pr were for the front end

@HLeithner
Copy link
Copy Markdown
Member

Fyi both pr were for the front end

hmm then I mixed something up and my argument makes no sense.

@brianteeman
Copy link
Copy Markdown
Contributor Author

my argument makes no sense.

Hence @mbabker comment

@HLeithner
Copy link
Copy Markdown
Member

Yeah, so if this works in 3.9.7 without problems I will merge the com tags merge into 3.9.8 and hopefully make everyone happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants