[4.0] [a11y] Remove redundant title from site components#24282
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Mar 21, 2019
Merged
[4.0] [a11y] Remove redundant title from site components#24282wilsonge merged 1 commit intojoomla:4.0-devfrom
wilsonge merged 1 commit intojoomla:4.0-devfrom
Conversation
The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it. It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice. This PR removes the redundant title attribute where the same text is already displayed and removes/replaces one language string where it wwas not needed NOTE this is just a first pass at removing the low hanging fruit and a further pr will be needed when the tooltips are reviewed
Contributor
|
Overriding system tests as appear to have broken in drone at the moment |
Contributor
Author
|
thanks |
Quy
reviewed
Mar 22, 2019
| <h3 class="page-header item-title"> | ||
| <?php if ( $this->params->get('show_cat_num_articles', 1)) : ?> | ||
| <span class="badge badge-info tip hasTooltip" title="<?php echo HTMLHelper::_('tooltipText', 'COM_CONTENT_NUM_ITEMS_TIP'); ?>"> | ||
| <span class="badge badge-info tip hasTooltip"> |
Contributor
There was a problem hiding this comment.
Remove tip hasTooltip.
Add <?php echo Text::_('COM_CONTENT_NUM_ITEMS'); ?>
Quy
reviewed
Mar 22, 2019
| <h3 class="page-header item-title"> | ||
| <?php if ( $this->params->get('show_cat_num_articles', 1)) : ?> | ||
| <span class="badge badge-info tip hasTooltip" title="<?php echo HTMLHelper::_('tooltipText', 'COM_CONTENT_NUM_ITEMS_TIP'); ?>"> | ||
| <span class="badge badge-info tip hasTooltip" title="<?php echo HTMLHelper::_('tooltipText', 'COM_CONTENT_NUM_ITEMS'); ?>"> |
Contributor
There was a problem hiding this comment.
Remove tip hasTooltip and title attribute.
Add <?php echo Text::_('COM_CONTENT_NUM_ITEMS'); ?>
Quy
reviewed
Mar 22, 2019
| <?php echo $this->escape($child->title); ?></a> | ||
| <?php if ( $this->params->get('show_cat_num_articles', 1)) : ?> | ||
| <span class="badge badge-info tip hasTooltip" title="<?php echo HTMLHelper::_('tooltipText', 'COM_CONTENT_NUM_ITEMS_TIP'); ?>"> | ||
| <span class="badge badge-info tip hasTooltip" title="<?php echo HTMLHelper::_('tooltipText', 'COM_CONTENT_NUM_ITEMS'); ?>"> |
Contributor
There was a problem hiding this comment.
Remove tip hasTooltip and title attribute.
Add <?php echo Text::_('COM_CONTENT_NUM_ITEMS'); ?>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it.
It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice.
This PR removes the redundant title attribute where the same text is already displayed and removes/replaces one language string where it was not needed
NOTE this is just a first pass at removing the low hanging fruit and a further pr will be needed when the tooltips are reviewed