[4.0] Redirect to CPanel when module in cpanel position has been edited#24271
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Mar 21, 2019
Merged
[4.0] Redirect to CPanel when module in cpanel position has been edited#24271wilsonge merged 1 commit intojoomla:4.0-devfrom
wilsonge merged 1 commit intojoomla:4.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 2780162 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24271. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing #23934
Pull Request for Issue #24109
Summary of Changes
Let's redirect to CPanel when a module has been edited from CPanel
Testing Instructions
Clean 4.0 branch install.
In CPanel edit a module via the dropdown
The module edit page is displayed
Before patch
Save and Close or Cancel redirects to the Admin Module Manager
After patch
The redirection is to the CPanel
Note: There may be other places in core where a redirect of this type should be done.
@chmst @C-Lodder