[4.0] [com_media] Various changes for the delete vue#24258
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Mar 20, 2019
Merged
[4.0] [com_media] Various changes for the delete vue#24258wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
Contributor
|
Looks good to me - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #23756 (comment)
Summary of Changes
Modified EOL to Unix for the
confirm-delete-modal.vuefileChanged the specific strings from
_MODEL_to_MODAL_Use the global string
JGLOBAL_CONFIRM_DELETEinstead of the newCOM_MEDIA_CONFIRM_DELETE_MODEL_DESCTesting Instructions
Patch. Run npm ci
After patch
Load the media manager. Select an item and click on the Delete button.
The modal will now look like this:
@Anu1601CS