[4.0] Fix inconsistency in order of toolbar buttons in com_users#24207
Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom Mar 21, 2019
Merged
[4.0] Fix inconsistency in order of toolbar buttons in com_users#24207wilsonge merged 3 commits intojoomla:4.0-devfrom
wilsonge merged 3 commits intojoomla:4.0-devfrom
Conversation
Contributor
Author
|
Also should I fix this for Modules of Site and Administrator as well ? |
Contributor
|
@hardik-codes yes, please make same order for all views. Thank you. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24207. |
Contributor
Author
|
@chmst now have a look |
Contributor
|
I have tested this item ✅ successfully on d9a45b0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24207. |
SharkyKZ
reviewed
Mar 18, 2019
Co-Authored-By: hardik-codes <hardik06agarwal@gmail.com>
Contributor
Author
|
one more tester please |
Contributor
|
Simple enough for one tester. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the following issue
All the toolbars are ordered "new - status - batch"
But the toolbar for com_users was "new - status - delete - batch"
The
deletebutton was in betweenstatusandbatchbuttons in this case, which was inconsistent with other toolbarsTesting Instructions
In the control panel
Go to Users => Manage
Expected result
Actual result
Documentation Changes Required
None