Skip to content

[4.0] Prepare Database for checked_out in workflow tables#24059

Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom
chmst:workflow-database-checkedout
Sep 24, 2019
Merged

[4.0] Prepare Database for checked_out in workflow tables#24059
wilsonge merged 6 commits intojoomla:4.0-devfrom
chmst:workflow-database-checkedout

Conversation

@chmst
Copy link
Copy Markdown
Contributor

@chmst chmst commented Mar 2, 2019

This pr adds the fields checked_out and checked_out_time to the workflow tables.
If this is done, the views of the workflow component can use the checked_out functions as other components.

Testing Instructions

Install a new application and inspect tables: workflows, workflow_stages and workflow_transitions.
Everything should work as before.

NOTE: I could test only the mysql database Would be great if I get help with testing the postgres part.

@chmst chmst changed the title Prepare Database for checked_out in workflow tables [4.0] Prepare Database for checked_out in workflow tables Mar 2, 2019
@amitranjan2
Copy link
Copy Markdown
Contributor


DEFAULT should be numeric 1
Please look at Line 6 also

@chmst
Copy link
Copy Markdown
Contributor Author

chmst commented Mar 2, 2019

@amitranjan2 you are right, there are also DEFAULT '0'. But this is not in scope of this PR, it is better you make an extra PR for this.

@amitranjan2
Copy link
Copy Markdown
Contributor

@amitranjan2 you are right, there are also DEFAULT '0'. But this is not in scope of this PR, it is better you make an extra PR for this.

Okay

@HLeithner
Copy link
Copy Markdown
Member

@alikon could you test this with pgsql?

@ghost ghost added the J4 Issue label Apr 5, 2019
@drmenzelit
Copy link
Copy Markdown
Collaborator

I have tested this item ✅ successfully on 766ac40

After applying the patch and installing Joomla! 4.0.0-alpha8-dev again I have the new columns checked_out and checked_out_time on the workflow tables.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24059.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Apr 8, 2019

on pgsql side seem's fine to me

@ghost
Copy link
Copy Markdown

ghost commented Apr 9, 2019

@alikon can you please mark your test as successfully?

@ghost ghost removed the J4 Issue label Apr 13, 2019
@VladikB
Copy link
Copy Markdown
Contributor

VladikB commented Sep 3, 2019

I have tested this item ✅ successfully on 5f8e751

Tested it on mysql


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24059.

@ghost
Copy link
Copy Markdown

ghost commented Sep 3, 2019

@drmenzelit can you please retest?

@drmenzelit
Copy link
Copy Markdown
Collaborator

I have tested this item ✅ successfully on 5f8e751


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24059.

@ghost
Copy link
Copy Markdown

ghost commented Sep 3, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 3, 2019
@wilsonge wilsonge merged commit 532a1f3 into joomla:4.0-dev Sep 24, 2019
@wilsonge
Copy link
Copy Markdown
Contributor

Thankyou!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 24, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 24, 2019
@chmst chmst deleted the workflow-database-checkedout branch October 5, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants