[4.0][a11y] 'Cancel' button changes from an anchor tag to a button tag (profile edit)#24007
[4.0][a11y] 'Cancel' button changes from an anchor tag to a button tag (profile edit)#24007tarot-ray wants to merge 7 commits intojoomla:4.0-devfrom
Conversation
For A11Y reasons, this should be a button tag, not a styled anchor tag.
|
This doesn't work. Button with |
|
I have tested this item 🔴 unsuccessfully on 9ce88b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24007. |
|
You still need to address the comments from @SharkyKZ |
|
I have tested this item ✅ successfully on 0b3c29f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24007. |
|
@tarot-ray almost there - in the latest commit you've accidentally removed the classes again :) |
|
@tarot-ray: Add: |
|
So, further changes have been made to the PR to make the line absolutely correct and perfectly A11Y compatible. Please, review. |
|
I have tested this item ✅ successfully on 74c891e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24007. |
|
LGTM! |
|
I have tested this item ✅ successfully on 30dd62a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24007. |
|
Just whitespace changes between the last two tests so RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24007. |
|
What exactly is the point of changing anchor to a button that does exactly the same but with JS dependency? |
|
@zwiastunsw Actually in this specific case thinking about it - I think a link was the correct choice because this is a redirect to another page. From http://web-accessibility.carnegiemuseums.org/content/buttons/ Basically buttons should be used if you're doing stuff on the same page and links for moving to another page |
|
@SharkyKZ , @wilsonge : |
|
See #24088 for potential alternative please. |
|
@wilsonge can this PR be closed? |
|
I've merged #24088 so closing this |
For A11Y reasons, this should be a button tag, not a styled anchor tag.
Pull Request for Issue # .
Summary of Changes
'Cancel' button is changed to a button tag from an anchor tag, to improved A11Y
Testing Instructions
Check that the 'Cancel' button is seen correctly by a screenreader.
Expected result
Improved A11Y.
Actual result
Documentation Changes Required