Deprecating several backend menu related classes for 4.0#23842
Merged
HLeithner merged 3 commits intojoomla:3.10-devfrom Feb 18, 2019
Merged
Deprecating several backend menu related classes for 4.0#23842HLeithner merged 3 commits intojoomla:3.10-devfrom
HLeithner merged 3 commits intojoomla:3.10-devfrom
Conversation
HLeithner
reviewed
Feb 17, 2019
| * | ||
| * @since 1.6 | ||
| * | ||
| * @deprecated 4.0 |
Member
Author
There was a problem hiding this comment.
This is not used in 3.9 already anymore and has been replaced with a completely different system. This deprecation notice should have been added wherever the flexible backend menu was added.
| * | ||
| * @since 3.8.0 | ||
| * | ||
| * @deprecated 4.0 |
Member
Author
There was a problem hiding this comment.
Again something that is not necessary in the system. If you need something like this, write it yourself. It's 5 lines of code.
| * | ||
| * @since 3.8.0 | ||
| * | ||
| * @deprecated 4.0 |
Member
Author
There was a problem hiding this comment.
This has no usefull purpose in 3.9 already. Tell me what it is used for and I remove the notice. It is not used in the menu system.
Member
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates a bunch of classes and methods for #23452