[4.0][a11y] Improve accessiblity in mod_finder#23686
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Mar 21, 2019
Merged
[4.0][a11y] Improve accessiblity in mod_finder#23686wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 49cee0b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23686. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 49cee0b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23686. |
Contributor
|
@zero-24 Please fix rips issues. |
Contributor
|
Rebooted drone @ http://ci.joomla.org/joomla/joomla-cms/13961 |
Contributor
|
Drone and Rips is happy now. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23686. |
|
I have tested this item ✅ successfully on 49cee0b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23686. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Improve a11y by adding role="search" to the form tag.
Testing Instructions
Add a finder module to your website.
Inspect the souce code before and after patch.