RTL: adapting display of Joomla versions plus some#23107
Merged
HLeithner merged 7 commits intojoomla:stagingfrom Jun 4, 2019
Merged
RTL: adapting display of Joomla versions plus some#23107HLeithner merged 7 commits intojoomla:stagingfrom
HLeithner merged 7 commits intojoomla:stagingfrom
Conversation
|
i see only at second and third Screenshot Differences between "Before" and "After" Patch. What are the Differences in first and fourth? |
Member
Author
|
@franz-wohlkoenig |
|
the Screenshots in #23107 (comment) |
Member
Author
|
I thought it was clear, sorry. Instead of |
|
I have tested this item ✅ successfully on 1ea122b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23107. |
Contributor
|
I have tested this item ✅ successfully on 3ea6168 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23107. |
|
Status "Ready To Commit". |
Member
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #21024 (comment)
Summary of Changes
As it was decided to allow Joomla updates to beta branches, the Joomla verions in RTL may now contain some latin characters.
The version should subsequently be displayed as LTR.
As I was at it, I also corrected the admin stats module display and the Maximum upload size MB figure.
Testing Instructions
In JoomlaUpdate Options choose Custom URL and add this link :
https://update.joomla.org/core/nightlies/next_major_list.xml
It will present the
4.0.0-alpha6-devupdateSave Options.
Install the Persian language.
Publish the mod_admin_stats module (Statistics) in cpanel position
With English as default admin language:
Display CPanel in one browser window and Joomlaupdate in another window (switch tabs there)
Make Persian as default admin language.
Reload the browser windows.
Apply patch and test again.
Before patch
After patch
@mbabker @rdeutz