[FIX} Calendar wrong locale variable#22026
Merged
zero-24 merged 1 commit intojoomla:stagingfrom Sep 7, 2018
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 9cb6150 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22026. |
Member
|
I have tested this item ✅ successfully on 9cb6150 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22026. |
|
Ready to Commit after two successful tests. |
Contributor
|
Thanks @infograf768 and @boomsya for reporting and fixing as well as the testers 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #22025
Summary of Changes
The calendar js is using the
clearvariable and not thesavevariable to clear the field.Therefore the button
Clearis NOT translated when using another language.The js code is clear ( 😄 )
this._nav_clear = hh(JoomlaCalLocale.clear, '', 100, 'button', '', 'js-btn btn btn-clear', {"type": "button", "data-action": "clear"});and not
save...Testing Instructions
Click on a calendar icon in backend publishing article tab and look at the buttons at the bottom when using another language than English (therefore not en-GB, en-US, en-Ca, etc if any)
Test in French
Before patch
After patch
@boomsya