[4.0] it shows that description of error to add new error type by durubayram · Pull Request #21384 · joomla/joomla-cms

durubayram · 2018-08-03T10:48:57Z

Pull Request for Issue #21249 .

Summary of Changes

by adding a new error type(COM_CONFIG_ERROR_VALIDATION) in ApplicationController.php file, you're going to be able to see description why form validation failed instead of getting an error which is 'No database selected'

Testing Instructions

Edit the Global configuration and provide an incorrect value for "session lifetime" : 19999
(it is possible to bypass the maximum value of the input field, which is 16383)

Expected result

The configuration is not saved and the user get a error message with the explanation of the issue which is 'Form validation failed. Please check the form.'

ghost · 2018-08-03T11:21:57Z

~~I have tested this item 🔴 unsuccessfully on 35e8d5b~~

~~19999 is saved and Message shows Constant.~~

Please ignore Test as for now Front- and Backend-PRs are able to test by Patchtester.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21384.}

SharkyKZ · 2018-08-03T11:22:48Z

Use error from model:
$this->app->enqueueMessage($model->getError(), 'error');

ghost · 2018-08-03T12:07:51Z

I have not tested this item.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21384.}

ghost · 2018-08-03T13:03:45Z

I have tested this item 🔴 unsuccessfully on 35e8d5b

19999 is saved and Message shows Constant.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21384.}

Twincarb · 2018-08-03T21:25:17Z

Is the PR missing the string being added to the language file?

wojsmol · 2018-08-03T22:02:43Z

@Twincarb yes

brianteeman · 2018-08-03T22:11:35Z

administrator/components/com_config/Controller/ApplicationController.php


 			// Redirect back to the edit screen.
-			$this->setRedirect(Route::_('index.php?option=com_config', false));
+            $this->app->enqueueMessage(\JText::_('COM_CONFIG_ERROR_VALIDATION'), 'error');


please use the namespaced code so this should be Text and not \JText

brianteeman · 2018-08-03T22:11:50Z

administrator/components/com_config/Controller/ApplicationController.php

 			// Redirect back to the edit screen.
-			$this->setRedirect(Route::_('index.php?option=com_config', false));
+            $this->app->enqueueMessage(\JText::_('COM_CONFIG_ERROR_VALIDATION'), 'error');
+            $this->app->redirect(\JRoute::_('index.php?option=com_config', false));


please use the namespaced code so this should be Route and not \JRoute

wojsmol · 2018-08-04T11:21:55Z

FILE: ...dministrator/components/com_config/Controller/ApplicationController.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 122 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 123 | ERROR | Tabs must be used to indent lines; spaces are not allowed
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

wojsmol · 2018-08-04T11:23:53Z

administrator/components/com_config/Controller/ApplicationController.php

 			// Redirect back to the edit screen.
-			$this->setRedirect(Route::_('index.php?option=com_config', false));
+            $this->app->enqueueMessage(Text::_('COM_CONFIG_ERROR_VALIDATION'), 'error');
+            $this->app->redirect(\JRoute::_('index.php?option=com_config', false));


use Route here

wilsonge · 2018-08-06T09:43:11Z

Codestyle fixed

brianteeman

approve language changes

brianteeman · 2018-08-06T11:17:53Z

I have tested this item ✅ successfully on 1a3c4eb

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21384.}

ghost · 2018-08-06T11:23:16Z

I have tested this item 🔴 unsuccessfully on 1a3c4eb

Language String shown correct, but incorrect value for "session lifetime" "19999" is saved

System information

Nightly Build 4.0.0-alpha5-dev
Multilingual Sample Data (French, German DE, Persian)
Template: Cassiopeia
macOS Sierra, 10.13.6
Firefox 61 (64-bit)

CloudAccess.net

PHP 7.1.15
MySQLi 5.7.18-cll-lve.
_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21384.}

obsidev · 2018-08-06T12:33:33Z

Hi,

The "session lifetime" is not saved in the configuration ; it is coming from the session which store the form data to not loose what the user was editing.
So the user know that the configuration is not saved but its form is kept which allow him to fix what is wrong (but he need to know what is wrong)

There is a comment saying that the model should display the error message (which is not the case and we don't know why).

The validate method enqueued all messages for us, so we just need to redirect back.

Letting the model display the errors or pushing the errors from the model is a requirement because the user must know what is going from with the provided data.
The patch fix the issue but it would require further improvements to have a good user experience.

Regards,

rmittl · 2019-10-19T08:54:35Z

Using "Blanks" before or after the value is accepted.
No error message - the value after saving is 15.
Example " 18005", "18005 " is value "15" after saving

Proposed solution, trim before check.

vijaykhollam · 2019-10-19T09:23:14Z

I have tested this item 🔴 unsuccessfully on 88726e0

#
Language String is shown correct, but incorrect value for "session lifetime" "19999" is saved

System information
Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
Web Server : Apache
WebServer to PHP Interface : cgi-fcgi
PHP 7.3.8
MySQL 5.7.23-cll-lve

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21384.}

pravinTek · 2019-10-19T10:01:44Z

Hi,
Now language string showing a correct message and also incorrect value for "session lifetime" "19999" is not storing in config.php
But In the backend UI System -> Global Configuration still showing "19999" this value under "session lifetime".

Quy · 2020-01-02T01:33:14Z

This is no longer an issue.

it shows that description of error to add new error type

35e8d5b

joomla-cms-bot added the PR-4.0-dev label Aug 3, 2018

ghost mentioned this pull request Aug 3, 2018

[4.0] com_config model validation issue #21249

Closed

Added language string

9b291d9

ghost mentioned this pull request Aug 3, 2018

[4.0] Fix 2nd level menu (atum template) not showing #21367

Merged

brianteeman reviewed Aug 3, 2018

View reviewed changes

joomla-cms-bot added the Language Change This is for Translators label Aug 4, 2018

Update ApplicationController.php

48590f8

wojsmol reviewed Aug 4, 2018

View reviewed changes

joomla-cms-bot changed the title ~~it shows that description of error to add new error type~~ [4.0] it shows that description of error to add new error type Aug 4, 2018

Fix tabs and use namespaced class

66962a2

Merge branch '4.0-dev' into 21249-fix-config-validation

1a3c4eb

brianteeman reviewed Aug 6, 2018

View reviewed changes

rdeutz added 2 commits August 8, 2018 20:28

Merge branch '4.0-dev' into 21249-fix-config-validation

8925905

Merge branch '4.0-dev' into 21249-fix-config-validation

88726e0

ghost added the J4 Issue label Apr 5, 2019

ghost removed the J4 Issue label Apr 13, 2019

Quy added the Conflicting Files label Nov 12, 2019

Quy closed this Jan 2, 2020

Uh oh!

Conversation

durubayram commented Aug 3, 2018

Summary of Changes

Testing Instructions

Expected result

Uh oh!

ghost commented Aug 3, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SharkyKZ commented Aug 3, 2018

Uh oh!

ghost commented Aug 3, 2018

Uh oh!

ghost commented Aug 3, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Twincarb commented Aug 3, 2018

Uh oh!

wojsmol commented Aug 3, 2018

Uh oh!

brianteeman Aug 3, 2018

Choose a reason for hiding this comment

Uh oh!

brianteeman Aug 3, 2018

Choose a reason for hiding this comment

Uh oh!

wojsmol commented Aug 4, 2018

Uh oh!

wojsmol Aug 4, 2018

Choose a reason for hiding this comment

Uh oh!

wilsonge commented Aug 6, 2018

Uh oh!

brianteeman left a comment

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Aug 6, 2018

Uh oh!

ghost commented Aug 6, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

System information

CloudAccess.net

Uh oh!

obsidev commented Aug 6, 2018

Uh oh!

rmittl commented Oct 19, 2019

Uh oh!

vijaykhollam commented Oct 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pravinTek commented Oct 19, 2019

Uh oh!

Quy commented Jan 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

ghost commented Aug 3, 2018 •

edited by ghost

Loading

ghost commented Aug 3, 2018 •

edited by ghost

Loading

ghost commented Aug 6, 2018 •

edited by ghost

Loading

vijaykhollam commented Oct 19, 2019 •

edited

Loading