Skip to content

[4.0] Namespace libraries/src#21243

Merged
wilsonge merged 11 commits intojoomla:4.0-devfrom
brianteeman:namespace_library_src
Jul 25, 2018
Merged

[4.0] Namespace libraries/src#21243
wilsonge merged 11 commits intojoomla:4.0-devfrom
brianteeman:namespace_library_src

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Jul 24, 2018

Continuing the namespace work

NOTE there are a lot of files in this folder and its hard to separate into smaller pr so I have decided to do it in batches ie test and merge this one which is the main namespacing and then do subsequent pr once merged for the remaining namespaces

wilsonge
wilsonge reviewed Jul 24, 2018
View reviewed changes
libraries/src/Application/CMSApplication.php
* @param string $request The name of the variable passed in a request.
* @param string $default The default value for the variable if not found. Optional.
* @param string $type Filter for the variable, for valid values see {@link \JFilterInput::clean()}. Optional.
* @param string $type Filter for the variable, for valid values see {@link InputFilter::clean()}. Optional.
Copy link
Copy Markdown
Contributor

@wilsonge wilsonge Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbabker does this need to be the fully qualified class for the @link tag to work or will just a normal use statement work?

Copy link
Copy Markdown
Contributor Author

@brianteeman brianteeman Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - i have no idea what i am doing - just trying to do the grunt work

Copy link
Copy Markdown
Contributor

@mbabker mbabker Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, see https://api.joomla.org/cms-3/classes/Joomla.CMS.Factory.html#method_getApplication

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jul 24, 2018

(currently unable to connect to ci.joomla.org to see what the drone errors are)

@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Jul 24, 2018

code style issues are the reason

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jul 24, 2018

I will have to look at it another day as for some reason my internet connection will not route to ci.joomla.ory so that I can see the issues

@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Jul 24, 2018 •
edited
Loading

I can help :-)


FILE: ...thub.com/joomla/joomla-cms/libraries/src/Installer/InstallerAdapter.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 125 | ERROR | Expected 2 spaces after the longest type
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ne/src/github.com/joomla/joomla-cms/libraries/src/Schema/ChangeItem.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 120 | ERROR | The variable names for parameters $db (1) and $file (2) do not
     |       | align
 137 | ERROR | The variable names for parameters $db (1) and $file (2) do not
     |       | align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...one/src/github.com/joomla/joomla-cms/libraries/src/Schema/ChangeSet.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  66 | ERROR | The variable names for parameters $db (1) and $folder (2) do not
     |       | align
 143 | ERROR | The variable names for parameters $db (1) and $folder (2) do not
     |       | align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: /drone/src/github.com/joomla/joomla-cms/libraries/src/UCM/UCMType.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 86 | ERROR | The variable names for parameters $alias (1) and $database (2) do
    |       | not align
 87 | ERROR | The variable names for parameters $database (2) and $application
    |       | (3) do not align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: /drone/src/github.com/joomla/joomla-cms/libraries/src/Date/Date.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 429 | ERROR | The variable names for parameters $local (1) and $db (2) do not
     |       | align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: /drone/src/github.com/joomla/joomla-cms/libraries/src/Table/Table.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 140 | ERROR | The variable names for parameters $key (2) and $db (3) do not
     |       | align
 141 | ERROR | The variable names for parameters $db (3) and $dispatcher (4) do
     |       | not align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jul 24, 2018

It will still have to wait until tomorrow as I am out for the evening. Unless you want to do a pr to my branch:)

@wilsonge wilsonge merged commit c8d43b9 into joomla:4.0-dev Jul 25, 2018
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jul 25, 2018
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jul 25, 2018

Thanks!

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jul 25, 2018

Thanks. Now to re-review this folder for the less common stuff

@brianteeman brianteeman deleted the namespace_library_src branch July 25, 2018 22:54
@rdeutz rdeutz mentioned this pull request Aug 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilsonge wilsonge wilsonge left review comments

@mbabker mbabker Awaiting requested review from mbabker

@rdeutz rdeutz Awaiting requested review from rdeutz

@zero-24 zero-24 Awaiting requested review from zero-24

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@brianteeman @rdeutz @wilsonge @mbabker @joomla-cms-bot