Closed
Conversation
Member
|
One cannot add a PR to correct an error in a PR which is not merged yet. In this case, it is better to correct the original PR or IF the original coder has disappeared, redo a full PR containing the whole code and all specific testing instructions, then ask Bugsquad to close the original PR. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21233. |
Member
Contributor
|
I am going to close this PR as #12543 is for testing purposes only. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The PR here #12543 generates an JS error, which is already in the system. This PR fix the error.
Testing Instructions
Apply the mentioned PR => JS error appears, apply patch => error disappear.
Expected result
No JS error
Actual result