[4.0] Replace "label" classes with the new "badge" ones#20328
Merged
wilsonge merged 242 commits intojoomla:4.0-devfrom Jun 14, 2018
htmgarcia:4.0-dev
Merged
[4.0] Replace "label" classes with the new "badge" ones#20328wilsonge merged 242 commits intojoomla:4.0-devfrom htmgarcia:4.0-dev
wilsonge merged 242 commits intojoomla:4.0-devfrom
htmgarcia:4.0-dev
Conversation
* [com_content] - archived legacy sef fix * cs
* Fix filter by multiple categories * Remove debug code
* Do not add unnecessary parameters in the archive link * Remove php notice * Unset parameter month=0 when year is not set
…19488) * move to protocol relative links to https * fix one broken font link
This reverts commit 05fd1d9.
Revert routing changes in 3.8.4
This reverts commit 0155f35.
This reverts commit 01a9147.
Revert content archive routing
Contributor
Author
|
@brianteeman @wilsonge may we merge this one, pretty please? |
Contributor
|
@htmgarcia it can't be merged until it passes all the tests it still has zero user tests |
Contributor
Author
Contributor
|
tests are reset when the code changes which you did when you resolved the conflicts |
Contributor
|
Found some more. Please see screenshot.
|
Contributor
|
There are 3 more in the screenshot that have to be replaced. |
Quy
reviewed
May 21, 2018
| </td> | ||
| <td> | ||
| <span class="label label-<?php echo $option->state ? 'success' : 'important'; ?>"> | ||
| <span class="badge badge-<?php echo $option->state ? 'success' : 'important'; ?>"> |
Contributor
There was a problem hiding this comment.
label-important is now badge-danger.
Contributor
|
Sorry these should be the last ones. |
Contributor
|
I have tested this item ✅ successfully on 59ed416 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20328. |
Contributor
|
Nice work! Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Replace "label" classes (not available in Bootstrap 4) with the new "badge" ones in frontend and backend
Testing Instructions
You can test in several places.
As example. Preview single articles that include tags in frontend
Expected result
The tags should have styling (color, background, etc) (with "badge" classes)
Actual result
The tags looks like regular links (with "label" classes)
Documentation Changes Required
Replacing the "label" classes with "badge" ones. That summarize this PR.