[4.0] Add space before the ellipsis#20135
[4.0] Add space before the ellipsis#20135laoneo merged 3 commits intojoomla:4.0-devfrom Quy:patch-13
Conversation
|
i need t check but i believe that for screenreaders to be able to read the word then there must be a space between the word and the elipsis |
|
In Print-Publishing there is also a Space between Letter and Ellipsis. The Space is small (1/8) and non-breakable. |
|
and the elipsis should be |
|
Not had time to check with a screen reader as I am at drupalcon regarding using three dots or the html entity However our style guide states that there should be a space before the dots |
Depends on the language I guess. In French no space at all for ellipsis, but 1/4 unbreakable before : or ! or ;, etc. |
|
Thats why we have language files :) and why the language string style guide is ONLY for en-GB |
|
comment undesired. I was just exchanging with @franz-wohlkoenig about print rules in different languages, not about web en-gb rules. |
|
@infograf768 thanks for Info, French Style was new to me. |
@brianteeman Please check which is the preferred syntax. Thanks. |
|
@Quy as i already wrote the stlyeguide says space dot dot dot - which is what you have and why I have approved this pr |
|
I have tested this item ✅ successfully on e70e93e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20135. |
|
One more test please for this simple PR. |
|
I have tested this item ✅ successfully on e70e93e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20135. |
Summary of Changes
To be consistent with the following language strings, add the space before the ellipsis.
Testing Instructions
Code review